Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document new dev admin permissions #399

Merged
merged 1 commit into from
Nov 14, 2023
Merged

DOC Document new dev admin permissions #399

merged 1 commit into from
Nov 14, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Nov 10, 2023
Closed
andrewandante
andrewandante suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@andrewandante andrewandante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, I'd add the actual name of the config option because as a dev, that's what I'm scanning for.

I think this page also needs to be updated: https://docs.silverstripe.org/en/5/developer_guides/controllers/builtin_middlewares/

en/04_Changelogs/5.2.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.2.0.md Show resolved Hide resolved
en/04_Changelogs/5.2.0.md Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/5/dev-admin-permissions branch from a181d07 to 2cc165e Compare November 10, 2023 01:04
@GuySartorelli
Copy link
Member Author

I think this page also needs to be updated: https://docs.silverstripe.org/en/5/developer_guides/controllers/builtin_middlewares/

What specific changes did you have in mind?

@andrewandante
Copy link
Contributor

andrewandante commented Nov 10, 2023 •
edited
Loading

I think this page also needs to be updated: https://docs.silverstripe.org/en/5/developer_guides/controllers/builtin_middlewares/

What specific changes did you have in mind?

Basically adding in a link to DevelopmentAdminConfirmationMiddleware along with the other ones, and a short description. Though I now note that it says some of them can be found here, so I guess it's up to you 😄

@GuySartorelli GuySartorelli force-pushed the pulls/5/dev-admin-permissions branch from 2cc165e to 9de4607 Compare November 12, 2023 20:12
@GuySartorelli
Copy link
Member Author

Added a row to the table on that page. Also added backticks to all items on that table.

@emteknetnz emteknetnz merged commit d989321 into silverstripe:5 Nov 14, 2023
@emteknetnz emteknetnz deleted the pulls/5/dev-admin-permissions branch November 14, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewandante andrewandante andrewandante approved these changes

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuySartorelli @andrewandante @emteknetnz